[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Console based mouse face highlighting.

From: Eli Zaretskii
Subject: Re: [PATCH] Console based mouse face highlighting.
Date: Sun, 13 May 2007 06:42:40 +0300

> From: Nick Roberts <address@hidden>
> Date: Sun, 13 May 2007 11:54:22 +1200
> Cc: address@hidden
> OK, thanks, that helped.   I've now replaced calls to x_y_to_hpos_vpos with
> code in that file.  It looks a bit better now, but the mouse highlighting
> is from text adjacent to the pointer, appears in a slightly different location
> and only when there is some input e.g a mouse click, and remains until I do
> a refresh (^L).

I'm afraid I don't quite understand what you are saying here.  What do
you mean by ``mouse highlighting is from text adjacent to the
pointer''? can you show an image or describe this with a specific
example?  Also, in what ``slightly different location'' does the
highlight appear?

> 1) Does write_glyphs *overwrite* existing glyphs (while insert_glyphs adds
>    to them) ?

Yes (on both accounts).  More accurately, write_glyphs simply dumps
the glyphs to the screen (with a call to fwrite), which on a tty will
overwrite whatever is displayed in the respective screen locations,
while insert_glyphs first switches the screen to insert mode, and then
calls write_glyphs.

> It would be nice if a comment said what these functions do.

Feel free to add comments.  Personally, I think the code speaks very
well for itself (I didn't write it), but that's me.

> 2) After a call to write_glyphs, does the cursor position move?

I'm not sure.  Why is this important?  Anyway, Emacs always
repositions the cursor at point at redisplay end.

> 3) Any hints on frame updating ? (both xterm.c and msdos.c use dpyinfo)

Sorry, I don't understand the question.  Please elaborate.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]