Re: crash: x_error_quitter

[Chong Yidong]

Jan Djärv <address@hidden> writes:

>>> The reason we make this crash is so we can find the causes and fix them.
>>
>> Except I don't think we've found a single legitimate bug this way.
>
> Yes we have.
>
>> Every time this comes up, we just end up adding yet another call to
>> x_catch_error.  Since X "protocol errors" are really more like warning
>> messages (as opposed to X "fatal errors"), I don't envision any other
>> situation cropping up.
>
> Depends on the error.  Some are really fatal.
>
>> But hey, CPU cycles are cheap these days, so what does it matter if we
>> plaster unnecessary x_catch_error calls all over the code.
>
> It can hide a real error that causes the protocol error in the first place.

What's wrong with spitting out an error message to the terminal and
trying to continue, as I believe other X programs do?