[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Icon displayed wrong

From: James Cloos
Subject: Re: Icon displayed wrong
Date: Sat, 19 May 2007 03:49:36 -0400
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.0 (gnu/linux)

>>>>> "Eli" == Eli Zaretskii <address@hidden> writes:

>> The problem with raw pgm files was fixed, but the cancel.pbm file should
>> still be replaced.  

Eli> Can you explain why?

The images directory has both B/W and Colour versions of each icon.  The
Colour versions are all xpm (X pixmap) files, and the B/W are all pbm
(Portable Bitmap) files.  All except cancel.pbm which has (had, on
trunk, now that Glenn updated it) the bitmap extension but is (was) a
grayscale file using only colours 0 and 255.

Converting it simply makes it match all of the other icons, and it
obviously was intended to be a P4 pbm file when it was first commited;
whoever saved it from Gimp just "typo"ed the SaveAs on that one file.

(Of course, it turns out that that was good for Emacs, since it pointed
out a bug which otherwise probably would not have yet been found.)

If there is any chance of .990 getting simply renamed as 22.1, then I
agree with Glenn's decision not to also make then change on the release
branch.  But it should then get done there for 22.2.

Since the PGM-in-PBM was obviously just a "typo" (mouse-o?), it is just
the Right Thing To Do.  At least on trunk, where it cannot delay the
pending release.  ;^)

James Cloos <address@hidden>         OpenPGP: 1024D/ED7DAEA6

reply via email to

[Prev in Thread] Current Thread [Next in Thread]