[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vc.el no longer recognizes files in an arch working directory

From: Stefan Monnier
Subject: Re: vc.el no longer recognizes files in an arch working directory
Date: Fri, 25 May 2007 10:47:31 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux)

> ... and the following patch seems to fix it:
> --- orig/lisp/vc-hooks.el
> +++ mod/lisp/vc-hooks.el
> @@ -325,7 +325,7 @@
>                     ;; to another user.  This should save us from looking in
>                     ;; things like /net and /afs.  This assumes that all the
>                     ;; files inside a project belong to the same user.
> -                   (not (equal user (file-attributes file)))
> +                   (not (equal user (nth 2 (file-attributes file))))
>                     (string-match vc-ignore-dir-regexp file)))
>        (if (file-exists-p (expand-file-name witness file))
>           (setq root file)

> So I'm going to commit this on the branch/trunk.

Oops, thanks.

> [Geez, people, please test stuff you commit on the release branch!]

Sorry 'bout the typo introduce when copy&pasting between the tested code and
the installed code.  But note that I'm surprised to see this code on
the release branch.  I never intended for it to go there, never committed
there AFAIK and when Richard asked me to install it on the release branch
I explicitly said I was not confortable doing it.

Looking at the CVS log I see:

   date: 2007-05-17 03:38:11 -0400;  author: gm;  state: Exp;  lines: +8 -1;  
commitid: wzJ1cmOAuE56Mfis;
   Sync change from trunk at request of rms in FOR-RELEASE:
   Stefan Monnier  <monnier at iro.umontreal.ca>
   (vc-find-root): Stop searching when the user changes.

So it looks like it was Richard's decision.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]