[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vera-mode.el

From: Stefan Monnier
Subject: Re: vera-mode.el
Date: Wed, 06 Jun 2007 14:03:01 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux)

> Attached is the latest version of the new vera-mode.el for review and
> addition to the Emacs distribution.

- What's end-comment-column?  Sounds like comment-fill-column.
- It seems the language allows both //...\n and /*...*/ for comments, but the
  comment-start-skip does not reflect that.  And it should also define the
  corresponding comment-end-skip.

- Also it should not (require 'font-lock) and neither should it call

- The call to easy-menu-define should be at toplevel rather than inside
  vera-mode.  And then the call to easy-menu-add should refer to
  vera-mode-menu rather than vera-mode-menu-list (which could be inlined
  into the call to easy-menu-define and then removed).

- The calls to modify-syntax-entry should not be at toplevel and neither
  should the (setq vera-mode-syntax-table (make-syntax-table)).  Best is to
  move it all inside the "defvar vera-mode-syntax-table" in the usual form
  (defvar vera-mode-syntax-table (let ((st (make-syntax-table))) ... st)).

-- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]