[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New VC mode -- review request

From: Dan Nicolaescu
Subject: Re: New VC mode -- review request
Date: Tue, 09 Oct 2007 08:33:04 -0700

"Eric S. Raymond" <address@hidden> writes:

  > Dan Nicolaescu <address@hidden>:
  > > BTW, I just found another issue:
  > > with the same setup as above, do: 
  > > cp ~/.emacs /tmp/test/3.el
  > > 
  > > emacs -q -l vc.el /tmp/test/3.el
  > > 
  > > C-x v v 
  > > fails with: "No fileset is available here."
  > That's correct, because the visited file isn't under version control.

That would be a change in long standing behavior, and it is
inconsistent with with to docstring for vc-next-action: "   If every
file is not already registered, this registers each one for version
control.  This does an add, but not a commit."
IMO this behavior is one of the strengths of vc: C-x v v always does TRT.

  > There's a design argument that maybe something different ought to happen 
  > but that's an after-the-merge issue.

Sure, just let's make sure it does not get forgotten.

Another post merge issue:
The code that deals with registering in vc-next-action:
    ;; Files aren't registered
     ((not state)
      (mapc 'vc-register files))

 Maybe vc-register could work on a list of files? vc-BACKEND-register
 already does that..

reply via email to

[Prev in Thread] Current Thread [Next in Thread]