[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: vc-git doesn't select current revision in vc-print-log
From: |
Dan Nicolaescu |
Subject: |
Re: vc-git doesn't select current revision in vc-print-log |
Date: |
Sat, 13 Oct 2007 10:29:13 -0700 |
"Chris Moore" <address@hidden> writes:
> Using "C-x v l" to show a file's revision history is supposed to
> select the current version in the log, but for git-controlled files it
> leaves point at the end.
>
> This is because (log-view-goto-rev rev) is called with REV bound to a
> branch name ("master", or whatever), but log-view-goto-rev can only
> match on the SHA1 hashes.
>
> It turns out that the current revision is always the first one in the
> list, since vc-print-log lists from the currently selected version
> backwards, so adding the following to vc-git.el fixes the problem:
>
> (defun vc-git-show-log-entry (rev)
> (goto-char (point-min))
> (log-view-msg-next))
That won't be correct, it ignores the rev argument.
If you want to work on this please talk to the vc-git author. I have
talked to him about this issue and he was thinking about a
solution...