emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: C-x v v no longer works the way it used to


From: Jim Meyering
Subject: Re: C-x v v no longer works the way it used to
Date: Sat, 20 Oct 2007 18:56:02 +0200

Dan Nicolaescu <address@hidden> wrote:
> Stefan Monnier <address@hidden> writes:
>
>   > > Before the recent vc changes, in a version-controlled directory,
>   > > if I were visiting a non-version-controlled file and hit C-x v v,
>   > > it would effectively add that single file to the version control
>   > > system.  i.e., cvs add, git add, etc.
>   >
>   > > Now, all it does is print "No fileset is available here."
>   >
>   > > Is this intentional?
>   >
>   > It's a bug.
>
> This patch fixes it.
> vc-next-action still has the logic to deal with unregistered files,
> but vc-deduce-fileset would not return one...
> This patch is technically incorrect because it changes
> vc-deduce-fileset to not do what it's docs says it has to do.
> Not sure how the new VC design is supposed to work to fix it
> properly...
>
> Index: vc.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
> retrieving revision 1.473
> diff -c -3 -p -c -r1.473 vc.el
> *** vc.el  19 Oct 2007 20:59:49 -0000   1.473
> --- vc.el  19 Oct 2007 22:47:56 -0000
> *************** Otherwise, throw an error."
> *** 1283,1288 ****
> --- 1282,1288 ----
>        (message "All version-controlled files below %s selected."
>                        default-directory)
>        (list default-directory)))
> +   ((not (vc-registered buffer-file-name)) (list buffer-file-name))
>     (t (error "No fileset is available here."))))

Thanks!
Works for me, though I'd rather it not prompt with
"Initial revision level for FILE_NAME: "

BTW, your patch didn't apply, so I applied it manually.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]