[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: doc-view compilation warnings
From: |
Stefan Monnier |
Subject: |
Re: doc-view compilation warnings |
Date: |
Tue, 23 Oct 2007 15:00:09 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) |
>> > +(push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist)
>> > +(push '("\\.[Dd][Vv][Ii]\\'" . doc-view-mode-maybe) auto-mode-alist)
>> > +(push '("\\.[Pp][Dd][Ff]\\'" . doc-view-mode-maybe) auto-mode-alist)
>>
>> In general loading a file should not have side effects like this.
>> IMHO, it is not idea to do things this way...
> So what would you suggest? A function `doc-view-initialize' that does
> this?
You could put it directly into files.el. Or (tho less good) put it into
`doc-view-mode' (so loading the file doesn't have any side-effect, though
using doc-view does).
> Oh, and the code has another problem: `push' is a cl function which may
> not be used at runtime...
No: `push' has never been a CL function: it used to be a CL macro and
nowadays it's a standard ELisp macro (tho CL replaces it with a turbocharged
version of it). So you can use it alright (tho you may prefer add-to-list
in order to avoid adding the entry several times).
Stefan
- doc-view compilation warnings, Miles Bader, 2007/10/20
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/21
- Re: doc-view compilation warnings, Richard Stallman, 2007/10/22
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/23
- Re: doc-view compilation warnings, Dan Nicolaescu, 2007/10/23
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/23
- Re: doc-view compilation warnings, Dan Nicolaescu, 2007/10/23
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/23
- Re: doc-view compilation warnings, Dan Nicolaescu, 2007/10/23
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/23
- Re: doc-view compilation warnings,
Stefan Monnier <=
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/23
- Re: doc-view compilation warnings, Stefan Monnier, 2007/10/23
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/24
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/24
- Re: doc-view compilation warnings, Tassilo Horn, 2007/10/24
- doc-view.patch waiting for installation (was: doc-view compilation warnings), Tassilo Horn, 2007/10/26
- Re: doc-view.patch waiting for installation, Glenn Morris, 2007/10/28
- Re: doc-view.patch waiting for installation, Tassilo Horn, 2007/10/29
- Re: doc-view.patch waiting for installation, Glenn Morris, 2007/10/30
- Case folding for auto-mode-alist (was: doc-view.patch waiting for installation), Reiner Steib, 2007/10/30