[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uninformative comment in files.el
From: |
Stefan Monnier |
Subject: |
Re: Uninformative comment in files.el |
Date: |
Wed, 12 Dec 2007 10:20:16 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) |
> After reading that thread (which I neglected to do beforehand, sorry) I
> still think that revert-buffer should remove all overlays and the mark.
I disagree. Anything that's not a minor mode will suffer from similar
problems and setting revert-buffer-function is not an option for them.
Your change will cause problems for the other category of minor-mode
like packages: those that need their overlays to survive a revert-buffer.
Blindly removing all overlays is drastic, and even more so if the only
way to prevent it is to set revert-buffer-function.
If a package needs to delete its hooks upon revert (e.g. cua-mode), then
it can use `before-revert-hook' and `after-revert-function'.
Stefan
PS: For what it's worth, I believe that those two hooks should be
applied regardless of revert-buffer-function.
- Uninformative comment in files.el, Stefan Monnier, 2007/12/11
- Re: Uninformative comment in files.el, Vinicius Jose Latorre, 2007/12/11
- Re: Uninformative comment in files.el, martin rudalics, 2007/12/11
- Re: Uninformative comment in files.el, Vinicius Jose Latorre, 2007/12/12
- Re: Uninformative comment in files.el,
Stefan Monnier <=
- Re: Uninformative comment in files.el, Yoni Rabkin Katzenell, 2007/12/12
- Re: Uninformative comment in files.el, Richard Stallman, 2007/12/13
- Re: Uninformative comment in files.el, Stefan Monnier, 2007/12/13
- Re: Uninformative comment in files.el, martin rudalics, 2007/12/13
- Re: Uninformative comment in files.el, David Kastrup, 2007/12/13
- Re: Uninformative comment in files.el, Richard Stallman, 2007/12/15
- Re: Uninformative comment in files.el, Richard Stallman, 2007/12/15
- Re: Uninformative comment in files.el, Stephen J. Turnbull, 2007/12/16
- Re: Uninformative comment in files.el, Richard Stallman, 2007/12/17
- Message not available
- Message not available
- Re: Uninformative comment in files.el, Richard Stallman, 2007/12/14