[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

VC mode bug with SVN: can't register files

From: Ted Zlatanov
Subject: VC mode bug with SVN: can't register files
Date: Fri, 04 Jan 2008 10:11:28 -0600
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux)

vc-registered returns t for unregistered SVN files, because
vc-svn-registered returns 'unregistered which is not nil.  This patches
vc-svn-registered to return nil in that case.

This fixes it, but a) I don't know if it's the right fix, and b) it may
need to be done for other backends as well, so 'unregistered may need to
be handled in vc-registered.  Since VC mode is in flux I didn't spend
more time on this or commit a fix, figuring it was better to report it.


Index: lisp/vc-svn.el
RCS file: /sources/emacs/emacs/lisp/vc-svn.el,v
retrieving revision 1.59
diff -u -r1.59 vc-svn.el
--- lisp/vc-svn.el      2 Jan 2008 00:42:36 -0000       1.59
+++ lisp/vc-svn.el      4 Jan 2008 16:02:03 -0000
@@ -132,7 +132,10 @@
                ;; an `error' by vc-do-command.
                (error nil))))
         (when (eq 0 status)
-          (vc-svn-parse-status file))))))
+          (let ((svn-status (vc-svn-parse-status file)))
+           (if (eq svn-status 'unregistered)
+               nil                                               
+             svn-status)))))))                                   
 (defun vc-svn-state (file &optional localp)                      
   "SVN-specific version of `vc-state'."                          

reply via email to

[Prev in Thread] Current Thread [Next in Thread]