[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Introducing 'unrecognized and 'ignored

From: Stefan Monnier
Subject: Re: Introducing 'unrecognized and 'ignored
Date: Sat, 19 Jan 2008 14:40:20 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

>> I'm not really sure about using generate-new-buffer-name here.
>> Presumably each vc-status buffer should have a single vc "work" buffer
>> as well.

> IMO yes. I did it that way for vc-hg. But it still needs some
> management: warn if the buffer already exist and refuse to start a new
> status command, remove the buffer after it has been processed.

Yes, maybe Tom is right, sorry for telling you to always use
a new buffer.  Part of the PCL-CVS could probably be reused here because
it shouldn't have any CVS dependency, but then again, it may not be
worth the trouble.

>> After trying this a couple times, I think the user needs an indication
>> of whether anything is running.  pcl-cvs puts this nicely in the
>> buffer... anyway, if you run vc-status on a directory with no changes,
>> it can be a little confusing as-is.

> Yep. vc-status-refresh and vc-update-vc-status-buffer can insert some
> start/end messages similar to PCL-CVS.

> It would be nice if we had something more general that is easily
> visible for buffers that use VC async commands. 

> Something like changing the background of a mode-line entry for VC
> buffers that are waiting for a command to compile. This should make it
> very easy to spot a buffer that is still executing some command.

There's the mode-line-process entry, but it's not visible enough.
Also the PCL-CVS way of putting the actual command in the buffer turned
out to be very useful to double-check what it is doing (and even more
so when several commands are running at the same time).

> log, diff and annotate could all use this functionality.

Indeed, they could use `mode-line-process'.

As for on-the-fly updating rather than updating in the end.  It's been
on my todo list for PCL-CVS, but I never got to it.  It'd probably be
a good idea to add this from the beginning because it substantially
changes the way things work: you have to use a process filter rather than
a sentinel, you have to check whether the partial output you have is
enough to parse it reliably or whether we need to way for more output,
and you have to be able to update the display incrementally.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]