Re: warning compiling dbusbind.c

[Michael Albinus]

Glenn Morris <address@hidden> writes:

> I receive this warning compiling dbusbind.c on x86_64 GNU/Linux with
> gcc 4.1:
>
> dbusbind.c: In function 'xd_retrieve_arg':
> dbusbind.c:600: warning: comparison is always false due to limited
> range of data type

The code in question is

        dbus_uint32_t val;
        dbus_message_iter_get_basic (iter, &val);
        XD_DEBUG_MESSAGE ("%c %d", dtype, val);
        return make_fixnum_or_float (val);

I've used make_fixnum_or_float, because BITS_PER_EMACS_INT is too small
on 32bit machines. One possible solution could be

        dbus_uint32_t val;
        dbus_message_iter_get_basic (iter, &val);
        XD_DEBUG_MESSAGE ("%c %d", dtype, val);
#if BITS_PER_EMACS_INT >= 32
        return make_number (val);
#else
        return make_fixnum_or_float (val);
#endif

On the other hand, shouldn't it be handled in make_fixnum_or_float?

Best regards, Michael.