[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compilation-next-error - extra `let' binding?

From: Stefan Monnier
Subject: Re: compilation-next-error - extra `let' binding?
Date: Sat, 09 Feb 2008 22:16:08 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

> Can't tell for sure without checking all of the code called by the
> body of the `let', but it looks like the `let' binding of `loc' in
> `compilation-next-error' is superfluous:
> (let* ((msg (get-text-property pt 'message))
>        (loc (car msg)) ; ???????
>        last)
> If so, taking out the binding would make the code easier to
> understand. If not, adding a comment for it might make the code easier
> to understand.
It's actually used by the compilation-loop macro.
I've added a comment to this effect.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]