[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: vc-*-root finctions
From: |
Thien-Thi Nguyen |
Subject: |
Re: vc-*-root finctions |
Date: |
Wed, 20 Feb 2008 19:21:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
() Stefan Monnier <address@hidden>
() Wed, 20 Feb 2008 12:21:55 -0500
This part I inferred, but of course it is necessary (weren't
you the guy complaining harshly about lack of comments in VC's
in-development code ;-)?
I said i find under-commenting obnoxious. Now i add: everyone is
free to be obnoxious -- makes life interesting. If these IMHOs
sound like harsh complaining, i must introduce you someday to my
two-year-old...
> I am using vc-BACKEND-root for (work-in-progress, see below)
> `vc-status-mode' munging.
I don't understand what for (in terms of user-level feature)?
Please see the `vc-status-mode' docstring in the updated code below.
This time i include a full patch for anyone interested in trying
it out. In terms of user experience, this means that doing:
M-x vc-status RET ~/build/MISC/ferm/examples RET
shows a buffer where the first line reads:
Directory: ~/build/MISC/ferm/examples/
and "ferm" (the project's "root" directory) is a button, which
means (for me) underlined and clickable, whose action is to do
`(vc-status "~/build/MISC/ferm")'.
If this explanation makes sense to you and the docstring doesn't,
could you suggest another wording?
thi
________________________________________________________________
one edit
* vc.el (vc-overview-p): New defsubst.
(vc-start-entry, vc-finish-logentry): Use it.
another edit
* vc.el (vc-status-headers): Delete func.
(vc-status, vc-status-mode, vc-status-refresh): Rewrite.
(vc-update-vc-status-buffer): Delete func.
* vc-svn.el (vc-svn-after-dir-status): Incorporate into...
(vc-svn-dir-status): ...here; update calling sequence.
* vc-hg.el (vc-hg-after-dir-status): Incorporate into...
(vc-hg-dir-status): ...here; update calling sequence.
* vc-git.el (vc-git-after-dir-status): Delete func.
(vc-git-dir-status): Rewrite.
full munging
.ttn.diff
Description: two edits
- vc-*-root finctions, Stefan Monnier, 2008/02/19
- Re: vc-*-root finctions, Thien-Thi Nguyen, 2008/02/20
- Re: vc-*-root finctions, Stefan Monnier, 2008/02/20
- Re: vc-*-root finctions,
Thien-Thi Nguyen <=
- Re: vc-*-root finctions, Dan Nicolaescu, 2008/02/20
- Re: vc-*-root finctions, Thien-Thi Nguyen, 2008/02/21
- Re: vc-*-root finctions, Dan Nicolaescu, 2008/02/21
- Re: vc-*-root finctions, Stefan Monnier, 2008/02/21
- Re: vc-*-root finctions, Tom Tromey, 2008/02/21
- Re: vc-*-root finctions, Dan Nicolaescu, 2008/02/21
- Re: vc-*-root finctions, Dan Nicolaescu, 2008/02/21
- Re: vc-*-root finctions, Tom Tromey, 2008/02/21
- Re: vc-*-root finctions, Dan Nicolaescu, 2008/02/21
- Re: vc-*-root finctions, Thien-Thi Nguyen, 2008/02/22