[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mode-line menu for minor modes
From: |
Dan Nicolaescu |
Subject: |
Re: mode-line menu for minor modes |
Date: |
Thu, 21 Feb 2008 01:17:09 -0800 |
"Drew Adams" <address@hidden> writes:
> > > > The new feature to pop a menu when clicking on the mode-line
> > > > :lighter for
> > > > minor modes is great.
> > > >
> > > > But for minor modes that don't provide a menu, just an error
> > > > message is
> > > > displayed: "No menu for minor mode `BLAH'". This is
> > > > not very helpful
> > > > for the user, it would be nicer to pop up a menu that
> > > > has (at least) 2
> > > > entries: - one to turn off the minor mode
> > > > - one to show the help for that minor mode.
> > > >
> > > > Yes, these are available elsewhere, but it's better to
> > > > provide something
> > > > useful and consistent for mouse-1 instead of just
> > > > complaining that a menu is not available.
> > >
> > > Good idea.
> >
> > Given that you wrote the rest of the minor mode menu popup
> > code, do you
> > want to implement this too?
>
> OK - see below.
Thank you!
> I wanted to make a patch, but apparently I don't know how to
> find the latest CVS version. When I look at what I think would be the latest
> version, namely the first download link at
> http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lisp/bindings.el?view=log, it
> shows a version of bindings.el that does not have the changes I submitted.
> But you are apparently seeing some version that does include that patch.
> If you tell me how to find the right version to patch, I'll send a patch. If
> not, here is the updated function definition - just substitute this for the
> definition I sent in my September patch.
cvs -d :pserver:address@hidden:/cvsroot/emacs co emacs/lisp/mouse.el
> Note: I added (sleep-for 1) because the turned-off message is otherwise
> erased immediately, at least in my environment. If it works for you without
> the sleep-for, then go ahead and remove it.
Works fine without it.
I also took out the read-event call.
I checked in your changes. Thanks!
- mode-line menu for minor modes, Dan Nicolaescu, 2008/02/19
- RE: mode-line menu for minor modes, Drew Adams, 2008/02/19
- Re: mode-line menu for minor modes, Dan Nicolaescu, 2008/02/20
- RE: mode-line menu for minor modes, Drew Adams, 2008/02/20
- Re: mode-line menu for minor modes,
Dan Nicolaescu <=
- RE: mode-line menu for minor modes, Drew Adams, 2008/02/21
- Re: mode-line menu for minor modes, Dan Nicolaescu, 2008/02/21
- Re: mode-line menu for minor modes, Bastien Guerry, 2008/02/25
- RE: mode-line menu for minor modes, Drew Adams, 2008/02/25
- Re: mode-line menu for minor modes, Bastien Guerry, 2008/02/25
- RE: mode-line menu for minor modes, Drew Adams, 2008/02/25
- Re: mode-line menu for minor modes, Stefan Monnier, 2008/02/25