[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 23.0.60; Cannot isearch for non-ascii chars with emacs -nw -Q

From: Kenichi Handa
Subject: Re: 23.0.60; Cannot isearch for non-ascii chars with emacs -nw -Q
Date: Thu, 28 Feb 2008 14:03:35 +0900
User-agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

In article <address@hidden>, Stefan Monnier <address@hidden> writes:

>>> > It seems that something is broken in isearch-x.el (although
>>> > unicode merge didn't change it).  I'm now investigating.

> > I found that when isearch-printing-char is called,
> > last-command-char is already what decoded by
> > encoded-kbd-mode.

> That's good, right?

I hope so.

> > But, when I wrote isearch-x.el, last-command-char was the first byte
> > of utf-8 sequence.  So, isearch-x.el pushed back that byte in
> > unread-command-events and re-read the whole utf-8 sequence.

> I see your patch doesn't remove this use of unread-command-events.
> Is it still needed?

This part in isearch-process-search-multibyte-characters
(isearch-x.el) is still necessary because it seems that the
user key is not yet handled by an input method.

        (if isearch-input-method-function

but the following part is not necessary any more (but not
harmful even if it is there).

        (if (and (not str) (keyboard-coding-system))
            (setq unread-command-events
                  (cons 'with-keyboard-coding
                        (cons last-char unread-command-events))
                  str (read-string prompt nil 'junk-hist)))

I'll delete that part after confirming it is ok.

>>> Now that we've moved the keyboard decoding to input-event-map,
> > Ah!  Is that the change I wrote above?

> I don't see why that change would have such an effect.
> Actually, it seems that this "new" behavior is already present in the 22
> branch, maybe even in Emacs-22.1.

But, it was before the release of 21 when I modified
isearch-x last time.

> > Yes.  I think it can be done by adding less than 100 lines
> > of C code (mostly for handling meta-key) in
> > tty_read_avail_input and removing most of encoded-kb.el (we
> > still need the code of calling set-input-mode property).

> Might worth trying,

I'll work on it after the current problems of font selection
are all solved.

Kenichi Handa

reply via email to

[Prev in Thread] Current Thread [Next in Thread]