Re: Large-file check in files.el

[Adrian Robert]

>  I'd call it "warn-about-large-file" or something like that and would let
>  it do the (error "Aborted!").

I did this and improved the doc.

------------

Index: files.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/files.el,v
retrieving revision 1.966
diff -c -b -r1.966 files.el
*** files.el    14 Mar 2008 17:14:09 -0000      1.966
--- files.el    2 Apr 2008 16:57:05 -0000
***************
*** 1507,1512 ****
--- 1507,1523 ----
    :version "22.1"
    :type '(choice integer (const :tag "Never request confirmation" nil)))

+ (defun abort-if-file-too-large (size op-type)
+   "If file SIZE larger than LARGE-FILE-WARNING-THRESHOLD, allow user to abort.
+ OP-TYPE specifies the file operation being performed (for message to user)."
+   (when (and large-file-warning-threshold size
+          (> size large-file-warning-threshold)
+          (not (y-or-n-p
+                (format "File %s is large (%dMB), really %s? "
+                        (file-name-nondirectory filename)
+                        (/ size 1048576) op-type))))
+         (error "Aborted")))
+
  (defun find-file-noselect (filename &optional nowarn rawfile wildcards)
    "Read file FILENAME into a buffer and return the buffer.
  If a buffer exists visiting FILENAME, return that one, but
***************
*** 1558,1573 ****
              (if (or find-file-existing-other-name find-file-visit-truename)
                  (setq buf other))))
        ;; Check to see if the file looks uncommonly large.
!       (when (and large-file-warning-threshold (nth 7 attributes)
!                  ;; Don't ask again if we already have the file or
!                  ;; if we're asked to be quiet.
!                  (not (or buf nowarn))
!                  (> (nth 7 attributes) large-file-warning-threshold)
!                  (not (y-or-n-p
!                        (format "File %s is large (%dMB), really open? "
!                                (file-name-nondirectory filename)
!                                  (/ (nth 7 attributes) 1048576)))))
!         (error "Aborted"))
        (if buf
            ;; We are using an existing buffer.
            (let (nonexistent)
--- 1569,1576 ----
              (if (or find-file-existing-other-name find-file-visit-truename)
                  (setq buf other))))
        ;; Check to see if the file looks uncommonly large.
!       (when (not (or buf nowarn))
!         (abort-if-file-too-large (nth 7 attributes) "open"))
        (if buf
            ;; We are using an existing buffer.
            (let (nonexistent)
***************
*** 1796,1801 ****
--- 1799,1806 ----
    (if (file-directory-p filename)
        (signal 'file-error (list "Opening input file" "file is a directory"
                                  filename)))
+   ;; Check whether the file is uncommonly large
+   (abort-if-file-too-large (nth 7 (file-attributes filename)) "insert")
    (let* ((buffer (find-buffer-visiting (abbreviate-file-name
(file-truename filename))
                                         #'buffer-modified-p))
           (tem (funcall insert-func filename)))