emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to hilight-chg not in emacs 22.1


From: Juanma Barranquero
Subject: Re: patch to hilight-chg not in emacs 22.1
Date: Fri, 25 Apr 2008 16:27:37 +0200

After this change:

2008-04-03  Richard Sharman  <address@hidden>

        * hilit-chg.el (highlight-changes-mode): Rename from
        highlight-changes; no longer uses sub-modes active and passive;
        implemented by define-minor-mode.
        (highlight-changes-toggle-visibility): New function, to replace
        the old passive/active submodes of global-highlight-changes-mode;
        implemented by define-minor-mode.
        (global-highlight-changes-mode): Rename from global-highlight-changes;
        rewrite using define-globalized-minor-mode.
        (hilit-chg-major-mode-hook, hilit-chg-check-global)
        (hilit-chg-post-command-hook, hilit-chg-check-global)
        (hilit-chg-update-all-buffers, hilit-chg-turn-off-maybe): Remove due
        to use of define-globalized-minor-mode.
        (highlight-changes-global-initial-state): Change to be boolean.
        (highlight-changes-visible-string, highlight-changes-invisible-string):
        Rename from highlight-changes-active-string and
        highlight-changes-passive-string.
        (hilit-chg-update, hilit-chg-set): Use them.
        (global-highlight-changes-mode): Rename from global-highlight-changes.
        (hilit-chg-map-changes, hilit-chg-display-changes): Add arguments to
        docstring.
        (hilit-chg-hide-changes): Rewrite to use dolist.
        (hilit-chg-set-face-on-change, hilit-chg-update)
        (highlight-changes-rotate-faces): Use highlight-changes-visible-mode
        variable instead of testing highlight-changes-mode.
        (highlight-markup-buffers): Add require ediff-util; argument on calls
        to highlight-changes-mode changed.
        (highlight-compare-with-file): Fix problems with interactive
        call giving invalid default file.

the file comments and the docstring of `highlight-changes-mode' still
reference `highlight-changes-disable-hook', which seem not to exist
anymore. I suppose that's an oversight and it should be obsoleted?
(And also `highlight-changes-enable-hook', which weirdly enough still
exists.)

 Juanma




reply via email to

[Prev in Thread] Current Thread [Next in Thread]