[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: byte-compile-nogroup-warn effectively disabled

From: Stefan Monnier
Subject: Re: byte-compile-nogroup-warn effectively disabled
Date: Sun, 08 Jun 2008 21:55:29 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> This change
>      ;; Warn if a custom definition fails to specify :group.
>      (defun byte-compile-nogroup-warn (form)

>     +  (if (and (memq (car form) '(custom-declare-face 
> custom-declare-variable))
>     +           byte-compile-current-group)
>     +      ;; The group will be provided implicitly.
>     +      nil

> effectively defeats the point of that warning, which is to
> make sure that every defcustom and defface specifies the group.

I know it's your opinion, and I disagree.  Even without an
explicit :group, the defcustom will have a proper group attributed to it
because it will use the last group defined in the file.  So, in my
opinion it fixes the warning so that it only occurs in cases where the
lack of the :group really leads to the variable being associated to no
group at all.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]