[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Zero height line causing arithmetic errors

From: Stefan Monnier
Subject: Zero height line causing arithmetic errors
Date: Sat, 14 Jun 2008 13:35:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

My MPC.el package uses an overlay placed at the end of a line with an
after-string of #("\n" 0 1 (face (:height 0.05 :inverse-video t)))
in order to place a horizontal line in the display.

In Emacs-22, this worked fine (except the line was a bit thicker than
0.05 times the base line height).  In Emacs-CVS until recently this
worked except that the line was full-height (i.e. 13 pixels in my case).
Recently, it has started to cause more problems because now
FRAME_SMALLEST_FONT_HEIGHT returns 0, and that value is used at 2 places
in the divisor position.

I guess the 0 is because 13 pixels (default font height) * 0.05 -> 0.65
pixels which are truncated to 0.

I currently use the patch below, which makes it all work again (tho
still with the problem that the 0.05 isn't taken into account and line
line is 13 pixel think), but I suspect it's not the right place to fix


=== modified file 'src/font.c'
--- src/font.c  2008-06-13 16:25:44 +0000
+++ src/font.c  2008-06-14 17:30:14 +0000
@@ -2682,6 +2682,7 @@
       if (FRAME_SMALLEST_FONT_HEIGHT (f) > font->height)
        FRAME_SMALLEST_FONT_HEIGHT (f) = font->height, fonts_changed_p = 1;
   return font_object;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]