[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: nxml-mode uses wrong method to run 'nxml-mode-hook

From: Stefan Monnier
Subject: Re: nxml-mode uses wrong method to run 'nxml-mode-hook
Date: Mon, 16 Jun 2008 12:34:11 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554;
>> your mileage may vary) has
>> (run-hooks 'nxml-mode-hook)
>> It should use 'run-mode-hooks', because this is a major mode
>> definition.  Can someone fix that?
>> It looks like there are some other major modes with the same problem.
>> For example: terminal-mode, view-mode, remember-mode, erc, rmail,
>> rcirc.  Most of the matches below are minor modes, though.
> The other major modes don't seem to be editing modes, and most of them have
> been in Emacs for a long time, so I am not sure if they should be changed,
> or if they have been left deliberately.

They should all use run-mode-hooks, AFAIK.  So unless there's a comment
justifying the use of `run-hooks', it should be changed.

> But I have changed nxml-mode.

Thank you,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]