emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Faces applies to new frames


From: Chong Yidong
Subject: Re: Faces applies to new frames
Date: Sat, 28 Jun 2008 22:48:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Regarding your recent change to face-set-after-frame-default: in the
loop that initializes faces from face specs and X resources, I believe
the reason this excluded the `default' face is that the `default' face's
attributes are supposed to be applied right at the beginning of
face-set-after-frame-default:

  (if (face-attribute 'default :font t)
      (set-face-attribute 'default frame :font
                          (face-attribute 'default :font t))
    (set-face-attribute 'default frame :family
                        (face-attribute 'default :family t))
    (set-face-attribute 'default frame :height
                        (face-attribute 'default :height t))
     ....

Thus, the function is simply trying to avoid doing the work twice.

The question is, why does this reasoning break down, leading to the bugs
that you supposedly fixed with your change?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]