[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] vc-find-root with invert

From: Stefan Monnier
Subject: Re: [patch] vc-find-root with invert
Date: Mon, 21 Jul 2008 14:32:16 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> Reading the docstring, my guess would be: vc-find-root walks the dir
>> tree up _until_ it finds WITNESS (as an evidence for the VC tree's root
>> dir). Unless we have CVS or SVN or similar, where every subdir has
>> WITNESS, so the root would be the last up-tree directory having WITNESS.

That still doesn't tell me what it does.  I mean I can read the code and
understand what is the effect of calling the code like this, but I have
no idea what effect it has for the user.  AFAICT it's a misfeature.

> This is exactly correct, though in the current trunk there is a bug
> such that the function does not behave like this. The patch causes it
> to work as documented.

I think we should remove this misfeature rather than fix it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]