emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] array index bug in 'hangul.el'


From: Lennart Borgman (gmail)
Subject: Re: [PATCH] array index bug in 'hangul.el'
Date: Mon, 11 Aug 2008 17:22:56 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666

Jihyun Cho wrote:
2008/8/11 Thien-Thi Nguyen <address@hidden>:
() "Jihyun Cho" <address@hidden>
() Mon, 11 Aug 2008 10:15:55 +0900

  Ok. I see.
  When you type the Korean Jongseong, bug occurs.
  So you can not type some characters in the Korean 3-Bulsik.
  I fixed it.

Juanma is asking for a specific form of explanation, one that can
be prepended to the ChangeLog file.  In this case, it is best if
you respond like so:

|Here's a suitable ChangeLog entry:
|
|YYYY-MM-DD  Jihyun Cho  <address@hidden>  (tiny change)
|
|       * quail/hangul.el (hangul3-input-method-jong): Fix typo.

The asterisk, parens and colon are part of the ChangeLog format.
The filename is relative to the closest directory (traveling towards
the root) that contains a ChangeLog file.  The parenthesized symbol
indicates the top-level form where the change occurs.  The blurb
"Fix typo" describes the change.

In this way, you show good spirit by playing the maintainer's role.

thi


Aha. I'm sorry.
Next time, I will care about to add to a suitable ChangeLog.

Though something more informative than "fix typo" would perhaps be good in a change like this? With just this information I would assume that it was a typo in the doc string. Maybe

  Fix typo in index bound, replaced 6 by 5.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]