[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: set-window-dedicated-p argument name

From: Juanma Barranquero
Subject: Re: set-window-dedicated-p argument name
Date: Wed, 22 Oct 2008 12:04:16 +0200

On Wed, Oct 22, 2008 at 11:35, martin rudalics <address@hidden> wrote:

> I didn't know about that thread.  AFAICT I have not broken anything here
> with respect to how this is documented.

I don't think the previous docstrings were good
(set-window-dedicated-p talked about a "dedication flag", while
window-dedicated-p referred to a "dedicated object", which was nowhere
explained). That said, with your wording it is not clear now that
w-d-p returns the object passed to s-w-d-p.

> If we want to consider a window
> dedicated iff `window-dedicated-p' equals t, we have to explicitly say
> that in the doc-string and the manual and then we can (re-)implement
> this or anything else that suits Stefan's needs.

I think at the moment the thing to do is consider a window dedicated
whenever FLAG is non-nil. If and when Stefan adds "different levels of
dedication", code affected by window dedication should be revised.

> Until now, it was
> possible to do
> (set-window-dedicated-p (selected-window) 1)
> and the window was _not_ considered dedicated by some functions.

I'd say that is a bug of these functions.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]