[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vc-bzr.el: avoid stomping files across hardlink branches.
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] vc-bzr.el: avoid stomping files across hardlink branches. |
Date: |
Sun, 09 Nov 2008 10:03:05 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
> I'm offering this patch for review before I commit, since I'm not an
> expert in the VC code. Following the patch is a shell script showing
> the reproduction recipe.
I don't really like this, because links can also be used for other
purposes than "copy on write". Most importantly your patch breaks
symlinks, which is usually the wrong thing to do.
In my opinion, the use of hardlinked trees is just risky business that
requires a lot of care, so I think priority should be given to handle
the "non-hardlinked tree" case correctly.
Stefan