[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reviewing changes

From: Stefan Monnier
Subject: Re: Reviewing changes
Date: Thu, 20 Nov 2008 23:01:00 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> IMO, if we cannot do it well, it isn't worth doing.

Sounds surprisingly dogmatic.

>> We already have code reviews, just rarely so.
> No, we don't.  What we have is random (and very rare) comments, and no
> mechanism to resolve disagreements when they happen.

So you object to naming them "code reviews"?  That's OK, let's call them
"random comments", then.

I just can't see how encouraging such random comments can hurt.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]