[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving fil

From: Stefan Monnier
Subject: Re: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Wed, 04 Feb 2009 14:46:49 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> The bug is that is uses buffer-size to determine the size of the file,
>> without taking into account the fact that
>> write-region-annotate-functions can add lot of stuff to the file that's
>> not in the buffer's text.
> How can buffer-size take that into account?

It can't.  Luckily we don't have to use buffer-size for that.

> The correct full size of what's written to the disk file is never
> seen, since write-region does its job piecemeal, and the annotations
> are applied separately to each piece by a_write.


> Am I missing something?

We do have all the annotations in a single place, so we can compute the
final total size before we start writing.

>> The simplest fix is to simply always output the message rather than only
>> for files larger than 50KB.
> That may be the only (non-kludgey) solution.

Yes, I find it to be the best solution.  I see no benefit in avoiding
the message for smaller files.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]