[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs/src fontset.c
From: |
Kenichi Handa |
Subject: |
Re: [Emacs-diffs] emacs/src fontset.c |
Date: |
Fri, 13 Mar 2009 14:29:37 +0900 |
In article <address@hidden>, Jason Rumney <address@hidden> writes:
> Kenichi Handa wrote:
> > By the way, after the following change, (frame-parameter nil
> > 'font) doesn't return a fontset of the current frame.
> >
> > 2009-01-14 Jason Rumney <address@hidden>
> >
> > * frame.c (x_set_font): Always store a font to the font parameter,
> > never a fontset. (Bug#1562)
> >
> > Now the right way to get a fontset is:
> > (face-attribute 'default :fontset)
> >
> Perhaps (frame-parameter nil 'fontset) could be made to work also.
But then, don't we have to think about the semantics of this?
(modify-frame-parameters nil '((fontset . ...)))
> I made that change because it seemed the most obvious way
> to fix Bug#1562,
I see.
> and since we have both FRAME_FONTSET (f)
> and FRAME_FONT (f), which in the previous code both
> returned fontsets under some circumstances. It seemed
> cleaner to have FRAME_FONTSET always return a fontset, and
> FRAME_FONT always return a font.
??? If there's a case that FRAME_FONT (f) returns a fontset,
it's a bug. In what circumstances, does it happen?
---
Kenichi Handa
address@hidden