[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

change-log-goto-source: recognising . within tag names

From: Bob Rogers
Subject: change-log-goto-source: recognising . within tag names
Date: Sat, 21 Mar 2009 22:49:41 -0400

   From: martin rudalics <address@hidden>
   Date: Fri, 20 Mar 2009 20:48:47 +0100

   . . .

   I'm afraid `change-log-search-tag-name' is too clever when trying to
   find a suitable tag.  Usually, it seems sufficient to search for the
   previous and next property change of the `change-log-list' text property
   near `point' and return the corresponding string.  Maybe we should
   provide a `change-log-search-tag-name-function' people could set to do
   the job.  Or, simply set the `syntax-table' text property to `symbol'
   for periods preceded _and_ followed by word/symbol characters.


A simple fix would be to find the file name first, read it into a buffer
(since we'll need it anyway), and then use its syntax table to parse the
tag name.  The code below is a start at this; it seems to work.  But it
would have to be integrated with the change-log-goto-source logic that
finds both the file at point and the file near the tag and then picks
the best one.  The logic seems rather obscure; I suspect I would break
it if I tried to change it.  ;-}

   From: Stephen Eglen <address@hidden>
   Date: Fri, 20 Mar 2009 10:22:42 +0000

   . . .

   This is also a problem in lisp, as it seems . can be used within lisp
   defuns (but not used in practice I think) . . .

As a matter of fact, lisp/ChangeLog.12 (and probably others) contain
elisp names with dots such as newsticker--parse-rss-1.0, which is why I
used this particular change log for testing.

   For Lisp in particular, the problem is actually fairly broad, as
people often use "+", "*", "$", "%", etc., to distinguish certain
definition names.  A better solution might be to ask the language mode
itself to do the name parsing, in order to handle such things as name
quoting conventions.  But, of course, that's a much bigger job.

                                        -- Bob Rogers

(defun change-log-file-and-tag ()
  ;; Find the nearest file first, then use that file's syntax table to
  ;; find the tag.
  (let ((file (change-log-search-file-name (point))))
    (if file
        (let* ((buffer (find-file-noselect file))
               (tag (with-syntax-table (with-current-buffer buffer
          (message "file %S tag %S" file tag)
          (list file tag)))))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]