Re: Printing

[YAMAMOTO Mitsuharu]

>>>>> On Mon, 06 Apr 2009 17:03:18 +0900, Kenichi Handa <address@hidden> said:

> [...]
> !     if (FT_Load_Char (ft_face, i, FT_LOAD_DEFAULT) == 0)
> [...]
> !       font->underline_thickness = ft_face->underline_thickness * size / 
> upEM;

> I've just comitted those changes.  Thank you for finding
> them.  Does the patch contain any other fixes?

Not in the patch, but I can find a similar code in xftfont.c for the
latter.  And maybe

  XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc,
                  x, y - font->ascent, width, y + font->descent);

in ftxfont_draw_backgrond (sic) should be

  XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc,
                  x, y - FONT_BASE (font), width, FONT_HEIGHT (font));

What do you think about the use of GC extension data in the patch?  It
allows us to extract information about clipping rectangles not from
struct glyph_string but from GC without using a wrapper.

                                     YAMAMOTO Mitsuharu
                                address@hidden