[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: load_charset warning
From: |
Kenichi Handa |
Subject: |
Re: load_charset warning |
Date: |
Fri, 01 May 2009 19:56:23 +0900 |
In article <address@hidden>, Emanuele Giaquinta <address@hidden> writes:
> gcc emits the following warning for charset.c:load_charset:
> charset.c: In function 'load_charset':
> charset.c:649: warning: comparisons like X<=Y<=Z do not have their
> mathematical meaning
> Since the code seems correct, i'd suggest the attached patch to
> improve readability (and avoid the warning).
Thank you. I committed your change.
---
Kenichi Handa
address@hidden
> diff --git a/src/charset.c b/src/charset.c
> index 15975a4..107647f 100644
> --- a/src/charset.c
> +++ b/src/charset.c
> @@ -646,7 +646,7 @@ load_charset (charset, control_flag)
> if (inhibit_load_charset_map
> && temp_charset_work
> && charset == temp_charset_work->current
> - && (control_flag == 2 == temp_charset_work->for_encoder))
> + && ((control_flag == 2) == temp_charset_work->for_encoder))
> return;
> if (CHARSET_METHOD (charset) == CHARSET_METHOD_MAP)