emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase


From: YAMAMOTO Mitsuharu
Subject: Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase
Date: Thu, 14 May 2009 08:48:56 +0900
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shij┼Ź) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI)

>>>>> On Wed, 13 May 2009 12:27:01 +0900, YAMAMOTO Mitsuharu <address@hidden> 
>>>>> said:

> If we remove the XrmDestroyDatabase call unconditionally, then it
> causes a memory leak when used with a newer libX11.  But that would
> be better than crashing when used with an older one.

Or maybe we can dissociate the resource database from the display
before closing it.

  #ifdef HAVE_XRMSETDATABASE
    XrmSetDatabase (dpyinfo->display, NULL);
  #else
    dpyinfo->display->db = NULL;
  #endif

Then we can ignore the difference of libX11 at least for normal close.

                                     YAMAMOTO Mitsuharu
                                address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]