Re: face-remap.el patch to resize window

[Miles Bader]

"Drew Adams" <address@hidden> writes:
>> How 'bout Miles's suggestion to use your code but without a separate
>> config var, using text-scale-mode-hook instead?  That would sound like
>> a good idea to me.
>
> (No reason given.) Why?

Well the obvious reason is that it avoids hard-wiring behavior which we
believe to be to inflexible, and is a smaller change.

[The hook, after all, already exists; my patch mainly just records a bit
more information for it to use.]

> I mentioned some disadvantages to using a hook.

Hmm, the only real disadvantage I can see is that hooks aren't
well-supported by customize.  [As for "buffer localness", hooks, after
all, can also be buffer-local, or can examine a buffer-local variable to
determine their behavior.]

> No one has mentioned any advantages.

See above:  Smaller; more flexible.

Hooks (like other indirection mechanisms) are generally more flexible,
at some cost in user-friendliness and clarity.  So if there's very
commonly desired behavior, sometimes it's good to hard-wire it instead
of telling people to use a hook or whatever (even if an appropriate hook
already exists).  However as I've mentioned, it's not clear to me that
the described behavior in this case is generally useful/universal enough
to hard-wire.

-Miles

-- 
`...the Soviet Union was sliding in to an economic collapse so comprehensive
 that in the end its factories produced not goods but bads: finished products
 less valuable than the raw materials they were made from.'  [The Economist]