[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Info about color-values need be revised

From: CHENG Gao
Subject: Re: Info about color-values need be revised
Date: Mon, 17 Aug 2009 01:32:33 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin)

*On Sun, 16 Aug 2009 08:30:53 -0700
* Also sprach "Drew Adams" <address@hidden>:

>> In ELISP manual, info about color-values is not true any more with NS
>> port merged. It says return value is (R G B).
>> In NS port, color-values uses function xw-color-values:
>> The return value is (R G B Alpha).
> Ouch! Why is that? Why does a platform-specific function change the meaning 
> of a
> generic function that way? And why should the generic function's signature be
> changed accordingly (breaking existing code)?
> Code that uses `color-values' depends on its return value being a 3-element
> list. That includes any NS code that uses `color-values' (as opposed to
> `xw-color-values'). Seems like any NS code that needs the Alpha info should 
> call
> `xw-color-values' directly (or some other NS-specific function) - and
> `color-values' should be left alone.

I dont have strong opinion or even weak opinion about what's right or
wrong. I just report my findings. As for what to do, it's up to Emacs

Ubi bene, ibi patria

reply via email to

[Prev in Thread] Current Thread [Next in Thread]