[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ange-ftp-file-size

From: Stefan Monnier
Subject: Re: ange-ftp-file-size
Date: Sat, 17 Oct 2009 22:03:06 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

>> Now that I look at it: isn't it problematic to set the mode to `ascii'
>> here?  If the mode was binary before and we call it with ascii-mode=nil,
>> we end up switching to ascii mode unwittingly, don't we?

> I read the code of `ange-ftp.el'.
> The follows is written...

>     In comments:

>         By default ange-ftp transfers files in ASCII mode.

>     In code:

>         (defun ange-ftp-...
>             ...
>               (unwind-protect
>                   (progn
>                     ...
>                     (if binary
>                         (ange-ftp-set-binary-mode host user))
>                     ...)
>                 (if binary
>                     (ange-ftp-set-ascii-mode host user)))
>             ...)

> So, I understood that `ASCII mode' is basic mode.
> I wrote after the style.
> (In my former patch, I should have used `unwind-protect'.)

OK, thanks, I've changed the prog2 to an unwind-protect.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]