[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ?
From: |
Eli Zaretskii |
Subject: |
Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ? |
Date: |
Sat, 24 Oct 2009 11:15:29 +0200 |
> From: Stefan Monnier <address@hidden>
> Date: Fri, 23 Oct 2009 21:05:05 -0400
> Cc: address@hidden, Andreas Schwab <address@hidden>,
> address@hidden
>
> Actually, when the cast was added in 2001, it came with the following
> commit-log-comment:
>
> (FIXNUM_OVERFLOW_P): Cast I to EMACS_INT in comparisons
> in case I is of some unsigned type, in which case
> MOST_NEGATIVE_FIXNUM will be converted to unsigned, and the
> comparison becomes bogus.
Right, sorry for my failing memory.
So I think the change made yesterday by Andreas should be reverted.
Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ?, Andreas Schwab, 2009/10/23
Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ?, Stefan Monnier, 2009/10/23