[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: vc-git: workaround for "file unregistered" problem

From: Stefan Monnier
Subject: Re: vc-git: workaround for "file unregistered" problem
Date: Thu, 12 Nov 2009 12:08:46 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

>>> Either way, specifying full paths works around the problem, and the
>>> patch below does that for those who encounter similar issues.
>> It looks acceptable, exept that, like all patches which try to work
>> around a problem, it should come with a corresponding comment.
> If only I understood the underlying problem better!
> I will try to do more research and check this in with an appropriate comment.

The comment doesn't need to explain the problem, but it needs to explain
why the code is written the way it is (e.g. "because if we use
a relative name Git seems to sometimes return incorrect data", ideally
even with a reference to the Git bug report).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]