emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dired auto-revert


From: Stefan Monnier
Subject: Re: Dired auto-revert
Date: Thu, 03 Dec 2009 21:15:31 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

> This patch provides a defcustom that allows specifying a predicate function
> for anyone who wants a non-standard auto-reverting.  By default it is nil
> preserving the current behavior.

Looks OK, except for the little docstring nitpick below:

> +If its value is a predicate function that checks if directory has
> +changed on disk, call this function with the directory name argument
> +and revert the buffer if it returns non-nil.

There's no way the code can check whether the value is "a predicate
function that checks if directory has changed on disk" (it's one of
those halting-problem-equivalent).
So really it should just say

   If its value is a function, call this function with the directory
   name as single argument and revert the buffer if it returns non-nil.


-- Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]