[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bookmark.el bug report
From: |
Thierry Volpiatto |
Subject: |
Re: bookmark.el bug report |
Date: |
Sat, 02 Jan 2010 08:03:47 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.90 (gnu/linux) |
Karl Fogel <address@hidden> writes:
> Karl Fogel <address@hidden> writes:
>>------------------------------------------------------------
>>revno: 99229
>>revision-id: address@hidden
>>parent: address@hidden
>>committer: Karl Fogel <address@hidden>
>>branch nick: trunk
>>timestamp: Fri 2010-01-01 23:36:17 -0500
>>message:
>> * lisp/bookmark.el: Improvements suggested by Drew Adams:
>> (bookmark-bmenu-ensure-position): New name for
>> `bookmark-bmenu-check-position'. Just ensure the position;
>> don't return any meaningful value.
>> (bookmark-bmenu-header-height, bookmark-bmenu-marks-width): New constants.
>
> And if I could edit the commit message for this one, I'd add:
>
> (everywhere): Adjust former callers of `bookmark-bmenu-check-position'
> to call `bookmark-bmenu-ensure-position' instead, and to not use the
> return value.
There is one bug also in bookmark-bmenu-hide-filenames where you forget
to put properties on bookmark when rebuilding.
So after one use of hide-/show-filenames, bookmark-bmenu-bookmark
doesn't work anymore because bookmark have no properties.
I sent a patch to Stefan.
--
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France
RE: bookmark.el bug report, Drew Adams, 2010/01/02