emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-21.1.94 crash in gnus on Windows


From: Eli Zaretskii
Subject: Re: emacs-21.1.94 crash in gnus on Windows
Date: Thu, 25 Mar 2010 06:14:01 +0200

> From: Chong Yidong <address@hidden>
> Cc: Andy Moreton <address@hidden>, address@hidden,
>         Eli Zaretskii <address@hidden>
> Date: Wed, 24 Mar 2010 17:34:14 -0400
> 
> However, looking at that recipe, it seems the problem is actually
> handled by my 2009-01-10 (it_method == GET_FROM_DISPLAY_VECTOR) change
> instead.  So either my 2008-01-26 change was bogus all along, or some
> other change in the meantime made it bogus.
> 
> I've reverted it in the branch; thanks for investigating.

But the part that you left in the code also uses it.glyph_row, which
is garbage after a call to move_it_to.  There's a single use of
it.glyph_row->x before the call to PRODUCE_GLYPHS (&it2), and I think
that needs to be fixed as well, because it potentially dereferences a
bad pointer.

Or did I miss something?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]