Re: kill-new may replace the wrong item

[Leo]

On 2 June 2010 20:53, Juri Linkov <address@hidden> wrote:
> Do you think `kill-do-not-save-duplicates' should take into account
> clipboard strings too and don't allow duplicates from clipboard?
> Maybe.  But should the same logic apply to the menu items of yank-menu?
> Should `menu-bar-update-yank-menu' use the value of `(car kill-ring)'
> that was *before* pushing clipboard into kill-ring, but the value of
> `replace' that is *after* pushing clipboard into kill-ring and
> comparing it with the new value of `(car kill-ring)'?

All I am trying to point out is there's something incorrect there.
When it detects the CAR is the same as the 'STRING' arg, there's
enough information to do something about it already, i.e.:

   (when (and kill-do-not-save-duplicates
              (equal string (car kill-ring)))
-    (setq replace t))
+    (pop kill-ring))
   (if (fboundp 'menu-bar-update-yank-menu)
       (menu-bar-update-yank-menu string (and replace (car kill-ring))))
   (when save-interprogram-paste-before-kill

is the old way of setting REPLACE to T is for the convenience of
menu-bar-update-yank-menu?

> --
> Juri Linkov
> http://www.jurta.org/emacs/

Leo