[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: split up process.c
From: |
Eli Zaretskii |
Subject: |
Re: split up process.c |
Date: |
Sun, 11 Jul 2010 09:10:38 +0300 |
> Cc: address@hidden
> From: Dan Nicolaescu <address@hidden>
> Date: Sat, 10 Jul 2010 23:40:57 -0400
>
> > There's now only one function, wait_reading_process_output, which has
> > 2 different implementations. (I could easily have a single function
> > with two different bodies conditioned by `subprocesses', or I could
> > move the second implementation to msdos.c, if people prefer that. But
> > both alternatives looked no cleaner, and the latter would even make
> > more maintenance headaches, IMO.)
>
> IMO it should go to msdos.c unless that requires other important code changes.
I will defer to Stefan and Yidong for the decision. Personally, I
think having a function with the same name on two different source
files will make maintenance a tad harder than it is when they are on
the same file.
> BTW, it's kind of funny that msdos.c has MSDOS and subpprocesses #ifdefs.
A long time ago I had plans to implement async subprocesses for the
MS-DOS port, and OTOH didn't dare to futz with non-MSDOS sources.
Thanks, I fixed this now (by reusing the similar definitions in
process.c).