emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bookmark from gnus article wrong modification


From: Thierry Volpiatto
Subject: bookmark from gnus article wrong modification
Date: Fri, 16 Jul 2010 15:16:38 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)

Hi,
the last modification for compatibility with older emacs in gnus-sum.el
is wrong.
You should use the value of pos what is set to point IN THE ARTICLE
BUFFER.
If you use just (point) it will record the value of point in the summary
buffer what is wrong and not what we want:

,----
|       `(,subject
|       ,@(condition-case nil
|             (bookmark-make-record-default 'no-file 'no-context (point))
|           (wrong-number-of-arguments
|            (bookmark-make-record-default 'point-only)))
`----

See precedent patchs for example.

Also this change add tabs that also is wrong i think (you should
untabify).

This changes occur in:

,----
| changeset:   109420:8fa1cd12c77f
| user:        Katsumi Yamaoka <address@hidden>
| date:        Thu Jul 15 00:54:06 2010 +0000
| summary:     Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
`----


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]