[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs-diffs Digest, Vol 94, Issue 89
From: |
David Kastrup |
Subject: |
Re: Emacs-diffs Digest, Vol 94, Issue 89 |
Date: |
Fri, 24 Sep 2010 22:29:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> Or maybe you mean that Stefan thought casting was not the best idea.
> In that case, I'd like Stefan's opinion on this one:
>
>> - int frame_lines = FRAME_LINES (frame);
>> + EMACS_INT frame_lines = FRAME_LINES (frame);
>
> I think down that lane lies madness, because we have lots of struct
> members that are Lisp integers, and assigning the result of XINT of
> every one of them to an EMACS_INT will significantly and unnecessarily
> increase our stack usage (on 64-bit machines).
"Significantly"? Reality check. How deep are you planning to recurse?
Are you still trying to fit a working Emacs into 64kB?
The significant costs are, if at all, in the structs containing the
"struct members" since in contrast to the automatic scalar variables of
a typical function that does rarely if ever recurse, there can be lots
of them at once, and apparently those _are_ already EMACS_INT, so _that_
cost, which is likely quite more significant, has already been paid
without people complaining.
--
David Kastrup
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Lars Magne Ingebrigtsen, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89,
David Kastrup <=
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, David Kastrup, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Chong Yidong, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/25
Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Lars Magne Ingebrigtsen, 2010/09/25