[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] compile.el bug in recognizing -o switches among

From: Stefan Monnier
Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among
Date: Fri, 29 Oct 2010 13:32:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>>> (by adding an outer pair of parentheses).  The correct regex is:
>>> " -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)"
>> Thanks, installed.
>> But, could you tell me how you made your patches?
>> Neither diff-mode nor `patch' understand their format:
> Thank you.  Responses like this to my feedback encourages me to spend more
> time on Emacs the next time.


> About the patch.  I manually edited the output from bzr diff.  I deleted
> what I thought was a comment line.  It looked like bzr had tried to
> extract the name of the enclosing function, but it had failed badly and
> pulled out part of an unrelated text literal.  I thought that letting it
> be could confuse human readers of the patch, but I guess I should have
> just deleted the text to the right of the ***********, not the entire
> line.

That was not specific to Bzr but to diff in general (controlled by the
"-p" flag) which just uses the last line that starts in column 0 as
a very simple heuristic.  So "patch" knows to ignore whatever follows
the ***************, and people used to reading context diffs also know
to ignore it.

FWIW, I usually prefer the unified context diff format (not that it
makes much difference in this case since it can also have this extra
"show function line" text).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]