[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: /srv/bzr/emacs/trunk r102179: Silence gnus-util.el compilation.

From: Stefan Monnier
Subject: Re: /srv/bzr/emacs/trunk r102179: Silence gnus-util.el compilation.
Date: Mon, 01 Nov 2010 14:08:59 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>>> -(autoload 'iswitchb-read-buffer "iswitchb")
>>> +(declare-function iswitchb-read-buffer "iswitchb"
>>> +             (prompt &optional default require-match start matches-set))
>>> +(defvar iswitchb-temp-buflist)
>>> +
>>> (defun gnus-iswitchb-completing-read (prompt collection &optional 
>>> require-match
>>> initial-input history def)
>>> "`iswitchb' based completing-read function."
>>> +  (require 'iswitchb)
>>> (let ((iswitchb-make-buflist-hook
>>> (lambda ()
>>> (setq iswitchb-temp-buflist
>> I'm not convinced that declare-function+require is better than autoload.
>> What was the problem with autoload?
> It might load iswitchb while an iswitchb variable was let bound. Eg:

I see, thanks.  Then it would have been good to add a comment before the
`require' reminding future readers why we did it this way.

> PS could you reply to emacs-devel rather than emacs-diffs in these cases?
> (I don't know why emacs-diffs is even configured to accept postings
> other than from Savannah.)

Yes, I get bitten by this all the time.  Indeed emacs-diffs should
refuse such postings.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]