[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unified mouse-highlight code needs testing

From: Jan Djärv
Subject: Re: Unified mouse-highlight code needs testing
Date: Sat, 06 Nov 2010 10:38:46 +0100
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv: Gecko/20101004 Thunderbird/3.1.5

Just some points, I'm still compiling.

As termchar.h now is a requrement because of MOUSE_HL_INFO, shouldn't lisp.h or or frame.h include it? nsfont.m didn't and failed to compile (fixed now).

Isn't a name like Mouse_HLInfo explicitly against the GNU coding standards?
Quote: "Stick to lower case; reserve upper case for macros and enum constants, and for name-prefixes that follow a uniform convention."

        Jan D.

Eli Zaretskii skrev 2010-11-06 09.56:
I've committed a few minutes ago to the trunk revision 102261, which
unifies the mouse-highlight code for all sessions, including GUI
sessions and text terminals that support the mouse (GPM and MSDOS).
There's now only one set of note_FOO_highlight functions (in xdisp.c)
and their subroutines that determine which parts of the displayed text
should be highlighted.  The only display-specific part is a single
function which actually draws a given glyph row in mouse-face.

I tested this on MS-Windows (as a representative of GUI sessions) and
on MSDOS.  I don't have access to a system with GPM which actually has
a mouse, so I could only make sure it builds with GPM and runs
correctly without a mouse.  I also made sure the X build compiles and

Please test the new code on a TTY with GPM, on X, and on NS.  On a TTY
with GPM, the immediate bonus from this unification is that now mode
line, header line, and overlays that specify mouse-face should all be
highlighted when the mouse hovers above them.  The easiest way of
testing this is in Info: you have there the mode line, the header
line, and the bread crumbs which all specify mouse-face; these should
all work now.

It is also important to test this in a session that has both X and TTY
frames, especially if the TTY frame uses GPM.

Thanks in advance.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]