[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert

From: Chong Yidong
Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert colors to hexadecimal with shr-color->hexadecimal.
Date: Tue, 23 Nov 2010 16:31:30 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Julien Danjou <address@hidden> writes:

> On Tue, Nov 23 2010, Chong Yidong wrote:
>> Why is this non-gnus-related library being checked into the Gnus
>> repository?
> Because it is used by Gnus?

By that logic, we should move all of Emacs into the Gnus tree.  This is
a general purpose library, not specific to Gnus.  It really ought to be
moved out into the Emacs tree.  If no one objects, I'm going to move it.

Also, it is going to have be be fixed.  For example, it violates
function naming conventions---some functions start with `color-lab',
others with `lab', and still others with no prefix at all.  All this
could have been caught if you'd posted the file to emacs-devel and gone
through the usual process of getting a library into the Emacs tree.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]